laminelam commented on PR #1508: URL: https://github.com/apache/solr/pull/1508#issuecomment-1544644362
> I think the classloader needs to be used in both `createZkCredentialsToAddAutomatically` and `createZkACLProvider` as well. Hi @HoustonPutman I think a solrClassLoader is not needed for _ZkACLProvider_ and _ZkCredentialsProvider_ except if we add in the future custom implementations part of another contrib/module, but it doesn't hurt to add it now. I have added it to both methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
