igiguere commented on code in PR #1632:
URL: https://github.com/apache/solr/pull/1632#discussion_r1192534779
##########
solr/core/src/java/org/apache/solr/rest/BaseSolrResource.java:
##########
@@ -143,7 +143,11 @@ protected void handleException(Logger log) {
Exception exception = getSolrResponse().getException();
if (null != exception) {
NamedList<Object> info = new SimpleOrderedMap<>();
- this.statusCode = ResponseUtils.getErrorInfo(exception, info, log);
+ boolean hideStackTrace =
+ solrCore != null
+ ? solrCore.getCoreContainer().hideStackTrace()
+ :
Boolean.parseBoolean(System.getProperty("solr.hideStackTrace"));
Review Comment:
addressed in commit cd8459605081f993ba6e16e5d0f631b3b4de60be
##########
solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java:
##########
@@ -70,10 +90,13 @@ public static int getErrorInfo(Throwable ex,
NamedList<Object> info, Logger log)
// For any regular code, don't include the stack trace
if (code == 500 || code < 100) {
- StringWriter sw = new StringWriter();
- ex.printStackTrace(new PrintWriter(sw));
- log.error("500 Exception", ex);
- info.add("trace", sw.toString());
+ // hide all stack traces, as configured
+ if (!hideStackTrace) {
+ StringWriter sw = new StringWriter();
+ ex.printStackTrace(new PrintWriter(sw));
+ log.error("500 Exception", ex);
+ info.add("trace", sw.toString());
Review Comment:
addressed in commit cd8459605081f993ba6e16e5d0f631b3b4de60be
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
