janhoy commented on code in PR #1634:
URL: https://github.com/apache/solr/pull/1634#discussion_r1195086445
##########
solr/core/src/java/org/apache/solr/cli/SimplePostTool.java:
##########
@@ -244,6 +253,12 @@ protected static SimplePostTool parseArgsAndInit(String[]
args) {
if (urlStr == null) {
urlStr = String.format(Locale.ROOT, "http://%s:%s/solr/%s/update";,
host, port, core);
}
+
+ // With bin/solr post you can't get here without a url string!
+ if (urlStr == null ) {
+ fatal("Specifying url is mandatory.\n" + USAGE_STRING_SHORT);
Review Comment:
This code will never be reached..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
