epugh commented on code in PR #1688:
URL: https://github.com/apache/solr/pull/1688#discussion_r1217923953


##########
solr/core/src/java/org/apache/solr/packagemanager/PackageUtils.java:
##########
@@ -268,17 +270,8 @@ public static void print(String color, Object message) {
   }
 
   public static String[] validateCollections(String collections[]) {

Review Comment:
   Actually, since we have a few places we use it, I think I like the explicit 
method...   Sometimes these stream style metods look a bit too clever!   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to