uschindler commented on code in PR #1653:
URL: https://github.com/apache/solr/pull/1653#discussion_r1222826668
##########
gradle/validation/forbidden-apis.gradle:
##########
@@ -49,11 +49,13 @@ allprojects { prj ->
logger.debug("Signature file omitted (does not exist): ${sig}")
}
}
-
+
// commons-io is special: forbiddenapis has a versioned bundledSignature.
- bundledSignatures += resolvedMods
- .findAll { id -> id.group == 'commons-io' && id.name == 'commons-io' }
- .collect { id -> "${id.name}-unsafe-${id.version}" as String }
+// bundledSignatures += resolvedMods
+// .findAll { id -> id.group == 'commons-io' && id.name == 'commons-io'
}
+// .collect { id -> "${id.name}-unsafe-${id.version}" as String }
+ // Hack until forbiddenapis supports commons-io 2.12.0
+ bundledSignatures += ['commons-io-unsafe-2.11.0']
Review Comment:
I have seen your PR for commons-io. I will update this.
Theres also another forbiddenapis issue to make the version parsing a bit
better for commons-io. So whenever a newer version is passed to the bundled
signatures it will fallback to the last recent version before the requested one.
This should solve issues like this in future. I just have no time before
bbuzz.... (my talk is still mostly unprepared)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
