janhoy commented on PR #1653: URL: https://github.com/apache/solr/pull/1653#issuecomment-1582376572
Confirmed that `TestCoreContainer.testDeleteBadCores` fails reproducibly with v2.13.0, while it passes with v2.11. The test attempt to clean up after a "bad core" where the instanceDir does not exist. commons-io v2.11 throws `java.nio.file.NoSuchFileException` which is caught in https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/core/SolrCore.java#L3334 But in commons-io v2.13 it throws `java.lang.IllegalArgumentException` with message: "File system element for parameter 'directory' does not exist": ``` java.lang.IllegalArgumentException: File system element for parameter 'directory' does not exist: '/Users/janhoy/git/solr/solr/core/build/tmp/tests-tmp/solr.core.TestCoreContainer_FC7F3677582ED11B-001/tempDir-001/badcore/data' at __randomizedtesting.SeedInfo.seed([FC7F3677582ED11B:8F28B8ED8131FDE0]:0) at org.apache.commons.io.file.PathUtils.requireExists(PathUtils.java:1396) at org.apache.commons.io.file.PathUtils.visitFileTree(PathUtils.java:1653) at org.apache.commons.io.file.PathUtils.lambda$deleteDirectory$0(PathUtils.java:503) at org.apache.commons.io.file.PathUtils.withPosixFileAttributes(PathUtils.java:1774) at org.apache.commons.io.file.PathUtils.deleteDirectory(PathUtils.java:502) at org.apache.commons.io.file.PathUtils.deleteDirectory(PathUtils.java:487) at org.apache.solr.core.SolrCore.deleteUnloadedCore(SolrCore.java:3333) at org.apache.solr.core.CoreContainer.unload(CoreContainer.java:2083) at org.apache.solr.core.TestCoreContainer.testDeleteBadCores(TestCoreContainer.java:341) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) ``` Spent some time digging, but lots of code has changed since last release in these delete calls. Have no time to pursue yet.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
