HoustonPutman commented on code in PR #1650:
URL: https://github.com/apache/solr/pull/1650#discussion_r1226892527
##########
solr/core/src/java/org/apache/solr/cluster/placement/PlacementPlugin.java:
##########
@@ -85,5 +104,80 @@ List<PlacementPlan> computePlacements(
*/
default void verifyAllowedModification(
ModificationRequest modificationRequest, PlacementContext
placementContext)
- throws PlacementModificationException, InterruptedException {}
+ throws PlacementException, InterruptedException {}
+
+ static Replica createProjectedReplica(
Review Comment:
I moved this up to OrderedNodePlacementPlugin, since it really should only
be used there, and I added javadocs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
