[
https://issues.apache.org/jira/browse/SOLR-16834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736862#comment-17736862
]
Bharat Gulati commented on SOLR-16834:
--------------------------------------
[~gerlowskija] i am not sure if I understood the code correctly, but this
parameter is being implicitly set as true in MoveReplicaCmd (in case of shared
file system) and SplitShardCmd and then passed on to AddReplicaCmd.
Based on this doc:
[https://solr.apache.org/guide/solr/latest/deployment-guide/replica-management.html]
these commands are related to manual admin activities that can be done on the
cluster.
I am still looking in it further, but so far it seems like it is not a
redundant property. I will try to comment out the releated lines and see if
regression test cases can unearth any potential issues.
> Remove unused AddReplicaCmd properties
> --------------------------------------
>
> Key: SOLR-16834
> URL: https://issues.apache.org/jira/browse/SOLR-16834
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
> Affects Versions: main (10.0)
> Reporter: Jason Gerlowski
> Priority: Minor
> Labels: newdev
>
> AddReplicaCmd currently has logic to read and use a parameter called
> 'skipCreateReplicaInClusterState' (which defaults to false). Unfortunately,
> CollectionsHandler doesn't actually pass that parameter.
> It looks like the parameter was added for use by the autoscaling "simulation"
> framework (see SOLR-11285). When that was cut from Solr later on the
> parameter was removed from CollectionsHandler, but the corresponding change
> to AddReplicaCmd was never made.
> We should remove
> [this|https://github.com/apache/solr/blob/c4a1b6ef2bb055b1b899677d01de704b6ecb620d/solr/core/src/java/org/apache/solr/cloud/api/collections/AddReplicaCmd.java#L122]
> line from AddReplicaCmd, and any other references to that now-defunct param.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
