gerlowskija commented on code in PR #1735:
URL: https://github.com/apache/solr/pull/1735#discussion_r1246740973


##########
solr/solr-ref-guide/modules/deployment-guide/pages/configuring-logging.adoc:
##########
@@ -172,6 +172,22 @@ The log file under which you can find all these queries is 
called `solr_slow_req
 In addition to the logging options described above, it's possible to log only 
a selected list of request parameters (such as those sent with queries) with an 
additional request parameter called `logParamsList`.
 See the section on 
xref:query-guide:common-query-parameters.adoc#logparamslist-parameter[logParamsList
 Parameter] for more information.
 
+== Selective Logging on SolrCore
+
+It can sometimes be noisy when `SolrCore` logs info on every response. 
Selective logging can be configured on SolrCore by using the `MarkerFilter` on 
request paths in `log4j2.xml`.

Review Comment:
   [0] Would a reader necessarily know what "SolrCore logs" are?  (i.e. that 
these are Solr's request logs). Or would it be better to call that out a bit 
more explicitly?
   
   > Solr logs all core/collection requests at INFO level using the 
`o.a.s.c.SolrCore.Request` and `o.a.s.c.SolrCore.SlowRequest` loggers.  This 
can be disabled entirely by changing the level of these loggers to `WARN` or 
`ERROR`, or administrators can configure more selective request logging on a 
per-path basis by using `MarkerFilter`...
   
   [Q] Is the marker stuff really only for the request logging in SolrCore, or 
is it also used for the HttpSolrCall request logging that's used for non-core 
(i.e. admin) requests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to