epugh commented on code in PR #1760:
URL: https://github.com/apache/solr/pull/1760#discussion_r1254902940
##########
solr/core/src/java/org/apache/solr/cli/RunExampleTool.java:
##########
@@ -326,98 +326,98 @@ protected void runExample(CommandLine cli, String
exampleName) throws Exception
"exampledocs directory not found, skipping indexing step for the
techproducts example");
}
} else if ("films".equals(exampleName) && !alreadyExists) {
- SolrClient solrClient = new Http2SolrClient.Builder(solrUrl).build();
+ try (SolrClient solrClient = new
Http2SolrClient.Builder(solrUrl).build()) {
+ echo("Adding dense vector field type to films schema \"_default\"");
+ try {
+ SolrCLI.postJsonToSolr(
Review Comment:
Look at all the string handling for JSON! I wondered about maybe using the
FieldTypeDefinition.java, but after looking at how it's used, it seems to add
another level of complexity/obfuscation over what is happening. I hope our
future V2 api's make doing thinks like adding a field type simpler and cleaner
;-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
