cpoerschke commented on code in PR #1578:
URL: https://github.com/apache/solr/pull/1578#discussion_r1255666294
##########
solr/core/src/test/org/apache/solr/core/TestCodecSupport.java:
##########
@@ -265,4 +266,27 @@ public void testCompressionModeDefault() throws
IOException {
coreContainer.unload(newCoreName);
}
}
+
+ public void testKnnVectorsFormat() {
+ Codec codec = h.getCore().getCodec();
+ Map<String, SchemaField> fields =
h.getCore().getLatestSchema().getFields();
+ SchemaField schemaField = fields.get("vector");
+
+ PerFieldKnnVectorsFormat format = (PerFieldKnnVectorsFormat)
codec.knnVectorsFormat();
+ assertEquals(
+ "Lucene95HnswVectorsFormat",
Review Comment:
minor: perhaps something like this could result in a compile-time rather
than test-run breakage when `Lucene95HnswVectorsFormat` becomes
`Lucene98HnswVectorsFormat` or so in a future Lucene version upgrade?
```suggestion
Lucene95HnswVectorsFormat.class.getName(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
