HoustonPutman commented on code in PR #1773:
URL: https://github.com/apache/solr/pull/1773#discussion_r1259852063
##########
solr/modules/s3-repository/src/java/org/apache/solr/s3/S3OutputStream.java:
##########
@@ -200,6 +202,10 @@ public MultipartUpload(String uploadId) {
}
void uploadPart(ByteArrayInputStream inputStream, long partSize) {
+ if (aborted) {
Review Comment:
this could just return like `complete()` below. Any reason to error here and
not there? It'd make the logic a bit simpler in `close()` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
