justinrsweeney commented on PR #1351: URL: https://github.com/apache/solr/pull/1351#issuecomment-1632477835
I like Option 4, I think having the hook added as its own PR + demonstration of use is enough for a single PR and opens up the ability to use this via plugins. If we were to go the route of supporting implementations, I think that could be a follow on PR because it opens up a different discussion of what are good supported implementations to be baked into Solr. I think the hook alone has clear value and should be merged as its own PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
