[
https://issues.apache.org/jira/browse/SOLR-15367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742462#comment-17742462
]
Alex Deparvu edited comment on SOLR-15367 at 7/12/23 3:25 PM:
--------------------------------------------------------------
[~dsmiley] This is very interesting. I am interested in putting together a poc
for this tracker based approach (based on some internal work I did to track
transactions across the Solr cluster).
What I think could be added to this feature:
* we can generate a new transaction id if missing. this is already called out
in the ticket description
* we could seed this tid based on incoming http readers. this is important
because we can 'onboard' Solr onto an existing app side tracing solution.
basically reuse transaction ids if they are there already.
* optionally allow for more than a single id (let's say for tracing purposes we
might have 2 incoming ids trace id and span id).
* make sure this tid is propagated to all inter-node requests
* place the id(s) in the MDC context - this is already mentioned
* update the logging config so all of this is logged - this could be manually
done (not necessarily on by default)
I have not done much work with the Tracers before, but I strongly believe this
is a pretty big gap on the debugging side in Solr, so I would like to give this
a go. Let me know what you think!
was (Author: alex.parvulescu):
[~dsmiley] This is very interesting. I am interested in putting together a poc
for this tracker based approach (based on some internal work I did to track
transactions across the Solr cluster).
What I think could be added to this feature:
* we can generate a new transaction id if missing. this is already called out
in the ticket description
* we could seed this tid based on incoming http readers. this is important
because we can 'onboard' Solr onto an existing app side tracing solution.
basically reuse transaction ids if they are there already.
* optionally allow for more than a single id (let's say for tracing purposes we
might have 2 incoming ids trace id and span id).
* place the id(s) in the MDC context - this is already mentioned
* update the logging config so all of this is logged - this could be manually
done (not necessarily on by default)
I have not done much work with the Tracers before, but I strongly believe this
is a pretty big gap on the debugging side in Solr, so I would like to give this
a go. Let me know what you think!
> Convert "rid" functionality into a default Tracer
> -------------------------------------------------
>
> Key: SOLR-15367
> URL: https://issues.apache.org/jira/browse/SOLR-15367
> Project: Solr
> Issue Type: Improvement
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
>
> Solr's "rid" (request ID) functionality added in SOLR-14566 could be
> converted into a distributed-tracing OpenTracing Tracer (Solr
> TracerConfigurator) plugin, more or less. Such an implementation, enabled by
> default, would merely generate IDs and pass them along in a custom HTTP
> header. Solr's existing tracing support would then ensure that this ID is in
> MDC in the "t:" log prefix, and thus would fit in nicely. "rid" is kind of a
> cheap bolt-on by comparison, duplicative with tracing but far fewer features.
> Solr's tracing support is growing, supporting more Solr-to-Solr interaction
> than "rid" which is only in a search request.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
