[
https://issues.apache.org/jira/browse/SOLR-16507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-16507:
--------------------------------
Description:
The NodeStateProvider is a relic relating to the old autoscaling framework that
was removed in Solr 9. The only remaining usage of it is for SplitShardCmd to
check the disk space. For this, it could use the metrics api. _(Update: keep
NodeStateProvider albeit simplify the default impl by removing Snitch stuff.
Add "NodeValueFetcher")_.
I think we'll observe that Snitch and other classes in
org.apache.solr.common.cloud.rule can be removed as well, as it's related to
NodeStateProvider.
Only
org.apache.solr.cluster.placement.impl.AttributeFetcherImpl#getMetricSnitchTag
and org.apache.solr.cluster.placement.impl.NodeMetricImpl refer to some
constants in the code to be removed. Those constants could move out,
consolidated somewhere we think is appropriate.
was:
The NodeStateProvider is a relic relating to the old autoscaling framework that
was removed in Solr 9. The only remaining usage of it is for SplitShardCmd to
check the disk space. For this, it could use the metrics api.
I think we'll observe that Snitch and other classes in
org.apache.solr.common.cloud.rule can be removed as well, as it's related to
NodeStateProvider.
Only
org.apache.solr.cluster.placement.impl.AttributeFetcherImpl#getMetricSnitchTag
and org.apache.solr.cluster.placement.impl.NodeMetricImpl refer to some
constants in the code to be removed. Those constants could move out,
consolidated somewhere we think is appropriate.
> Remove Snitch. Simplify NodeStateProvider usage.
> -------------------------------------------------
>
> Key: SOLR-16507
> URL: https://issues.apache.org/jira/browse/SOLR-16507
> Project: Solr
> Issue Type: Task
> Reporter: David Smiley
> Assignee: Noble Paul
> Priority: Major
> Labels: newdev
> Fix For: 9.3
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> The NodeStateProvider is a relic relating to the old autoscaling framework
> that was removed in Solr 9. The only remaining usage of it is for
> SplitShardCmd to check the disk space. For this, it could use the metrics
> api. _(Update: keep NodeStateProvider albeit simplify the default impl by
> removing Snitch stuff. Add "NodeValueFetcher")_.
> I think we'll observe that Snitch and other classes in
> org.apache.solr.common.cloud.rule can be removed as well, as it's related to
> NodeStateProvider.
> Only
> org.apache.solr.cluster.placement.impl.AttributeFetcherImpl#getMetricSnitchTag
> and org.apache.solr.cluster.placement.impl.NodeMetricImpl refer to some
> constants in the code to be removed. Those constants could move out,
> consolidated somewhere we think is appropriate.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
