stillalex commented on code in PR #1778: URL: https://github.com/apache/solr/pull/1778#discussion_r1275089478
########## solr/core/src/java/org/apache/solr/handler/admin/api/APIConfigProvider.java: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.handler.admin.api; + +import org.apache.solr.handler.admin.api.APIConfigProvider.APIConfig; +import org.glassfish.hk2.api.Factory; + +/** + * Interface to be implemented by the Request Handlers that need to provide some custom Review Comment: > I don't feel strongly, but maybe this interface should live in o.a.s.jersey, since it's pretty tied in to JAX-RS/Jersey. agreed. class moved > Could v2 API classes that are unaffiliated with any request handler implement this interface, or does this only work with RequestHandler's for now? (Either is fine; just trying to understand.) right now it's restricted to `ApiSupport` classes that jersey registers, so not specifically handlers. this could be easily extended as needed if we need to introduce a new way of handling apis/configs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
