gerlowskija commented on PR #1793: URL: https://github.com/apache/solr/pull/1793#issuecomment-1652129601
One thing I don't think anyone has commented on yet is the structure of the generated SolrRequest classes - do those look reasonable as-is, or is there something missing? (e.g. Factory or builder methods like we have in CollectionAdminRequest?). I guess there's no pressure to lock in the exact SolrRequest code at this point, since the APIs are v2 and therefore experimental and subject to change anyways. But it feels remiss to not ask the question given the templates in this PR 🤷 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
