epugh commented on code in PR #1810:
URL: https://github.com/apache/solr/pull/1810#discussion_r1279847230
##########
solr/solrj/src/java/org/apache/solr/common/util/Utils.java:
##########
@@ -712,7 +712,7 @@ public static String getBaseUrlForNodeName(
}
final String hostAndPort = nodeName.substring(0, _offset);
final String path = URLDecoder.decode(nodeName.substring(1 + _offset),
UTF_8);
Review Comment:
Good catch. So, at one time we needed the path variable to decide if you
had `/solr/mysubsolr` etc.. but now, we have just `/solr` so this can be
eliminated actually!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
