radu-gheorghe commented on PR #596: URL: https://github.com/apache/solr-operator/pull/596#issuecomment-1668054762
My 2 cents: * good stuff, I think a queue is needed, thanks for implementing it 🙏 * I think it's awesome that you added docs about how things work! * Do we need to retry operations? I'm thinking that if we just dropped operations that e.g. timed out or errored out, the reconcile loop will naturally retry, no? Especially in the context of HPA, I bet it re-evaluates whether the current cluster has enough horsepower * Along the same lines, is there a priority that's linked to different kinds of requests? For example, if we had a scaleUp operation and a scaleDown operation came about, I would assume that whoever came last should win. And that maybe a rolling upgrade (if started) should ideally complete before we start scaling, otherwise we might get in trouble? Either way, I can't wait to try this autoscaling in more complex setups 🤓 Exciting stuff! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
