dsmiley commented on code in PR #1761:
URL: https://github.com/apache/solr/pull/1761#discussion_r1286173971
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java:
##########
@@ -506,30 +507,23 @@ private static NamedList<Object>
waitForCoreAdminAsyncCallToComplete(
}
String r = (String)
srsp.getSolrResponse().getResponse().get("STATUS");
- if (r.equals("running")) {
Review Comment:
Why don't we change this to a `switch` statement? Even IntelliJ is
recommending this :-) It seems an underlying bug here would have been averted
had a switch statement been used as it sort of forces you to consider all the
enum values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
