epugh commented on code in PR #1808:
URL: https://github.com/apache/solr/pull/1808#discussion_r1286973313


##########
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##########
@@ -474,6 +509,8 @@ public static String resolveSolrUrl(CommandLine cli) throws 
Exception {
           solrUrl = 
ZkStateReader.from(cloudSolrClient).getBaseUrlForNodeName(firstLiveNode);
         }
       }
+    } else {
+      solrUrl = resolveSolrUrl(solrUrl);

Review Comment:
   Yeah, I redid it, took out some nesting to make it easier to read, and fix 
this...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to