dsmiley commented on code in PR #1835:
URL: https://github.com/apache/solr/pull/1835#discussion_r1298882024


##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/CommitStream.java:
##########
@@ -55,6 +55,7 @@ public class CommitStream extends TupleStream implements 
Expressible {
   private TupleStream tupleSource;
 
   private transient SolrClientCache clientCache;
+  private transient boolean isCloseCache;

Review Comment:
   The name "isCloseCache" is clumsy IMO; I think "doCloseCache" is far clearer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to