stillalex commented on PR #1854: URL: https://github.com/apache/solr/pull/1854#issuecomment-1685416582
@dsmiley thank you for the review so far. I managed to successfully move the functionality to solr-core without extra dependencies (just api and context). I think this allows for much more freedom with enabling by default and eventually (maybe) replacing the rid. I updated the test and something weird failed. it seems the `UpdateRequest` does not actually propagate headers to internal communication? I'm not even sure if this is by design or not. I added a todo to verify. My plan (given this moved to core) would be to turn this into a 'on by default' behavior (add a flag to allow disabling). Optionally I would source rid from this value, so that there is no confusion between multiple similar sets of values. Please take another look and let me know what you think so far. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
