[
https://issues.apache.org/jira/browse/SOLR-15367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758710#comment-17758710
]
Alex Deparvu commented on SOLR-15367:
-------------------------------------
There is only a piece missing here, the rid part. I don't want to remove it
right away, but rather slowly deprecate it.
My plan is to introduce 2 configs:
- "solr.disableRequestId" - defaults to false (could be turned on in the
future, this is the deprecation path) which can disable the entire rid
generation. right now a client can pass a query param called 'disableRequestId'
but that is not system wide. if you go for full OTEL you might not need rid, so
this gives you the freedom to disable it
- "solr.traceAsRequestId" - defaults to true. the always-on trace ids have
similar structure (host-counter) but are not in sync with rid. this fixes that
problem, making 'rid' the same as 'trace id'
What would happen after this change introduced:
- if you are passing rid as a param
-- nothing changes, it will get attached to all query requests
- if you are not passing rid
-- you can disable it, so you don't see it if you don't want it - you will
have trace ids
-- OR keep it
--- based on the trace ids - more useful for the always-on setups. <- this is
the default
--- based on previous generator - more useful for OTEL setups
[~dsmiley] [~hossman] thoughts?
> Convert "rid" functionality into a default Tracer
> -------------------------------------------------
>
> Key: SOLR-15367
> URL: https://issues.apache.org/jira/browse/SOLR-15367
> Project: Solr
> Issue Type: Improvement
> Components: tracing
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> Solr's "rid" (request ID) functionality added in SOLR-14566 could be
> converted into a distributed-tracing OpenTracing Tracer (Solr
> TracerConfigurator) plugin, more or less. Such an implementation, enabled by
> default, would merely generate IDs and pass them along in a custom HTTP
> header. Solr's existing tracing support would then ensure that this ID is in
> MDC in the "t:" log prefix, and thus would fit in nicely. "rid" is kind of a
> cheap bolt-on by comparison, duplicative with tracing but far fewer features.
> Solr's tracing support is growing, supporting more Solr-to-Solr interaction
> than "rid" which is only in a search request.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
