[
https://issues.apache.org/jira/browse/SOLR-16950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16950:
--------------------------------
Description:
This only applies to the always-on simple tracer. Being able to pass in a
custom trace header and have it correctly propagated across the cluster in all
types of requests is a big feature of this component.
I noticed that there are UpdateRequests that will not correctly propagate a
manual trace headers, due to the fact that the Solr client can recreate the
UpdateRequest without copying the headers over top the new request.
There is a failing test I commented out to showcase the issue
https://github.com/apache/solr/blob/ce6c13e41806233daaf25f1a7545c7aad34c169d/solr/core/src/test/org/apache/solr/util/tracing/TestSimplePropagatorDistributedTracing.java#L75
was:
This only applies to the always-on simple tracer. I noticed that there are
UpdateRequests that will not correctly propagate a manual trace headers, due to
the fact that the Solr client can recreate the UpdateRequest without copying
the headers over top the new request.
There is a failing test I commented out to showcase the issue
https://github.com/apache/solr/blob/ce6c13e41806233daaf25f1a7545c7aad34c169d/solr/core/src/test/org/apache/solr/util/tracing/TestSimplePropagatorDistributedTracing.java#L75
> SimpleTracer propagation for manual transaction ids
> -----------------------------------------------------
>
> Key: SOLR-16950
> URL: https://issues.apache.org/jira/browse/SOLR-16950
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: tracing
> Reporter: Alex Deparvu
> Assignee: Alex Deparvu
> Priority: Minor
>
> This only applies to the always-on simple tracer. Being able to pass in a
> custom trace header and have it correctly propagated across the cluster in
> all types of requests is a big feature of this component.
> I noticed that there are UpdateRequests that will not correctly propagate a
> manual trace headers, due to the fact that the Solr client can recreate the
> UpdateRequest without copying the headers over top the new request.
> There is a failing test I commented out to showcase the issue
> https://github.com/apache/solr/blob/ce6c13e41806233daaf25f1a7545c7aad34c169d/solr/core/src/test/org/apache/solr/util/tracing/TestSimplePropagatorDistributedTracing.java#L75
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
