psalagnac commented on PR #1864: URL: https://github.com/apache/solr/pull/1864#issuecomment-1693795795
> this looks very good! much easier to follow along! > the only minor suggestion would be to add the `isExpensive()` method to implementors of `CoreAdminAPIBase` which look like candidates for expensiveness: `BackupCoreAPI`, `RestoreCoreAPI` maybe other too but I don't really know. Thanks for pointing this @stillalex . My understanding is the are backup/restore operations for API V2, correct? Yes, they definitely should also be marked as expensive operations. Will change this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
