cpoerschke commented on code in PR #96:
URL: https://github.com/apache/solr/pull/96#discussion_r1310549161
##########
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java:
##########
@@ -96,11 +91,46 @@ public String getErrorMessage() {
+ allowedCPUUsage.get();
}
+ public void setThreshold(double thresholdValueInPercentage) {
+ if (thresholdValueInPercentage > 100) {
+ throw new IllegalArgumentException("Invalid Invalid threshold value.");
+ }
+
+ if (thresholdValueInPercentage <= 0) {
+ throw new IllegalStateException("Threshold cannot be less than or equal
to zero");
+ }
+ cpuUsageThreshold = thresholdValueInPercentage;
+ }
+
public double getCpuUsageThreshold() {
return cpuUsageThreshold;
}
+ @SuppressWarnings("rawtypes")
Review Comment:
in favour of line 125
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
