dsmiley commented on code in PR #1351:
URL: https://github.com/apache/solr/pull/1351#discussion_r1310891181
##########
solr/test-framework/src/java/org/apache/solr/util/TestHarness.java:
##########
@@ -186,6 +187,9 @@ public TestHarness(NodeConfig config, CoresLocator
coresLocator) {
}
public static NodeConfig buildTestNodeConfig(Path solrHome) {
+ if ("true".equals(System.getProperty("solr.tests.loadSolrXml"))) {
+ return SolrXmlConfig.fromSolrHome(solrHome, new Properties());
+ }
Review Comment:
FYI I'm trying to get us off of using TestHarness; it's very legacy. I
recommend avoiding it for new tests.
https://issues.apache.org/jira/browse/SOLR-11872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
