magibney commented on code in PR #1351:
URL: https://github.com/apache/solr/pull/1351#discussion_r1311015770
##########
solr/test-framework/src/java/org/apache/solr/util/TestHarness.java:
##########
@@ -186,6 +187,9 @@ public TestHarness(NodeConfig config, CoresLocator
coresLocator) {
}
public static NodeConfig buildTestNodeConfig(Path solrHome) {
+ if ("true".equals(System.getProperty("solr.tests.loadSolrXml"))) {
+ return SolrXmlConfig.fromSolrHome(solrHome, new Properties());
+ }
Review Comment:
Sorry about that! I'm curious, if it's not too much trouble: is there a test
you'd recommend as demonstrating a more modern pattern -- particularly one that
modifies `solr.xml` _and_ goes all the way through indexing/querying? It was
hard enough for me to track down any way to do this at all, let alone the right
way.
I don't mind circling back to improve this, since it's in the front of my
mind now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
