gerlowskija opened a new pull request, #1885:
URL: https://github.com/apache/solr/pull/1885

   https://issues.apache.org/jira/browse/SOLR-16825
   
   
   # Description
   
   Many of Solr's api definitions rely on `@Produces` annotation to explicitly 
declare the response content types that they support.
   
   But it turns out that this wasn't ever really necessary - Jersey can match 
the API invocation up with an appropriate MessageBodyWriter without the help of 
this annotation.  Only those APIs that want to specifically restrict their 
response formats need by annotated.
   
   Ultimately it's a minor problem, but in addition to cluttering up our API 
definitions these annotations also are the cause of some noisy messages in our 
build logs. 
   
   
   # Solution
   
   All `@Produces` annotations have been removed from the `api` submodule.  
We'll need this annotation for some APIs that are very selective about their 
response content-type (e.g. our ZooKeeper-read APIs, /export, etc.).  But 
almost all of its usages are removed by this PR.
   
   # Tests
   
   Manual testing; automated tests continue to pass.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `main` branch.
   - [x] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to