epugh commented on code in PR #1886:
URL: https://github.com/apache/solr/pull/1886#discussion_r1313815652
##########
solr/core/src/test/org/apache/solr/search/TestThinCache.java:
##########
@@ -126,35 +176,4 @@ public void testInitCore() throws Exception {
// for the other node-level cache, simply check that metrics are accessible
assertEquals(0,
nodeMetricsSnapshot.get("CACHE.nodeLevelCache/myNodeLevelCache.size"));
}
-
- @BeforeClass
Review Comment:
Could we have patterns like that caught in precommit or lint checker?
These are the kinds of things that should be checked automatically for us.
not putting lifecycle methods at the bottom isn't an actual pattern that I knew
about for example ;-). We need more support in keeping formatting clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
