janhoy commented on code in PR #1871:
URL: https://github.com/apache/solr/pull/1871#discussion_r1315609098
##########
solr/core/src/test-files/solr/collection1/conf/solrconfig-pluggable-circuitbreaker.xml:
##########
@@ -80,6 +80,18 @@
<circuitBreaker class="solr.MemoryCircuitBreaker">
<double name="threshold">75</double>
+ <arr name="requestTypes">
+ <str>update</str>
+ </arr>
+ </circuitBreaker>
+
+ <circuitBreaker class="solr.MemoryCircuitBreaker">
+ <double name="threshold">80</double>
+<!-- Default is search
Review Comment:
```suggestion
<!-- Default is query
```
##########
solr/core/src/test-files/solr/collection1/conf/solrconfig-pluggable-circuitbreaker.xml:
##########
@@ -80,6 +80,18 @@
<circuitBreaker class="solr.MemoryCircuitBreaker">
<double name="threshold">75</double>
+ <arr name="requestTypes">
+ <str>update</str>
+ </arr>
+ </circuitBreaker>
+
+ <circuitBreaker class="solr.MemoryCircuitBreaker">
+ <double name="threshold">80</double>
+<!-- Default is search
+ <arr name="requestTypes">
+ <str>search</str>
Review Comment:
```suggestion
<str>query</str>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
