dsmiley commented on code in PR #1898:
URL: https://github.com/apache/solr/pull/1898#discussion_r1319297522
##########
solr/solrj/src/java/org/apache/solr/common/params/CommonParams.java:
##########
@@ -277,9 +279,23 @@ public static EchoParamStyle get(String v) {
* <p>Defaults to 'false' if not specified.
*
* @see #REQUEST_ID
+ * @see #DISABLE_REQUEST_ID_DEFAULT
+ * @deprecated this was replaced by the auto-generated trace ids
*/
+ @Deprecated(since = "9.4")
String DISABLE_REQUEST_ID = "disableRequestId";
+ /**
+ * An opt-out flag to prevent the addition of {@link #REQUEST_ID} tracing on
distributed queries
+ *
+ * <p>Defaults to 'false' if not specified.
+ *
+ * @see #DISABLE_REQUEST_ID
+ * @deprecated this was replaced by the auto-generated trace ids
+ */
+ @Deprecated(since = "9.4")
+ boolean DISABLE_REQUEST_ID_DEFAULT =
Boolean.getBoolean("solr.disableRequestId");
Review Comment:
Admittedly I hate seeing values in the Params classes but this practice
started long ago and I see you are attempting to match some loosely followed
conventions.
##########
solr/solr-ref-guide/modules/deployment-guide/pages/distributed-tracing.adoc:
##########
@@ -25,6 +25,17 @@ A sampled distributed tracing query request displayed in
Jaeger UI looks like th
.Tracing of a Solr query
image::distributed-tracing/query-request-tracing.png[]
+== Always-on Trace Id generation
+
+Starting from 9.4 Solr ships with an always-on trace id generator. This will
inject trace id headers for every Solr request, propagating the client supplied
value or generating a new id as needed and replaces the existing `rid`
mechanism.
+
+The header name it uses for propagation is `X-Trace-Id`, this can be changed
by updating the system property `solr.traceIdHeader`.
+
+This plugin will not be enabled if another Tracing mechanism is setup via Solr
config.
+This plugin can be disabled by setting the `solr.alwaysOnTraceId` system
property to `false`.
+
+Note: Solr 9.4 ships with an `OpenTracing` based lightweight `Tracer`
implementation and Solr 10 has an updated `OpenTelemetry` based
`TextMapPropagator` implementation.
+
Review Comment:
@ctargett at some point did you say something about reference guide style in
which we shouldn't refer to older or newer versions? After all, the ref guide
is itself versioned. I don't think you said exactly that but I recall you said
something similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
