patsonluk commented on PR #1457: URL: https://github.com/apache/solr/pull/1457#issuecomment-1714423429
> This looks really useful -- indeed basically _required_ in order to specifically target certain kinds of race/deadlock issues. Basically identical in spirit to `injectDelay()`, but more nuanced and reliable. > > I left one minor suggestion, but aside from that, I'm wondering if it might be better to introduce this along with the PR that presumably motivated its addition? I think on usefulness it stands in its own right, but it might be clearer in terms of commit history to bundle this as incorporated with a concrete use case. Would you mind to review https://github.com/apache/solr/pull/1460 ? :) that PR actually contains this breakpoint change too and uses it. I have added extra logging when breakpoint is triggered to that branch instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
