HoustonPutman commented on PR #1912: URL: https://github.com/apache/solr/pull/1912#issuecomment-1714423565
> I love it... I wonder though if we should think about having a explicit "integration" tests subdir? We use BATS for both "unit testing" our Bash scripts, but also now are using it more and more to run a integration or End 2 End test for Solr. (For example, my adding a test to verify stand alone Solr replication!)... Maybe for another ticket if we find that these bats tests start taking a REALLY long time. Yeah I guess we could move the bash scripts somewhere else, but I think this is a fine place for the "integration" tests. Overall I think this is a separate issue though, since there already are integration tests here, and this is testing the bash stuff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
