tizianodeg opened a new pull request, #1917:
URL: https://github.com/apache/solr/pull/1917
https://issues.apache.org/jira/browse/SOLR-16973
# Description
On windows RMI can not be enabled using the solr.in.cmd.
This is because the REMOTE_JMX_OPTS is changed in solr.cmd but it is used as
static %REMOTE_JMX_OPTS% instead using delayed expansion !REMOTE_JMX_OPTS!
# Solution
use !REMOTE_JMX_OPTS! instead of %REMOTE_JMX_OPTS%
# Tests
manual tested by enabling RMI on windows
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms
to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request
title.
- [x] I have given Solr maintainers
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [-] I have run `./gradlew check`.
- [-] I have added tests for my changes.
- [-] I have added documentation for the [Reference
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
