tflobbe commented on PR #1931: URL: https://github.com/apache/solr/pull/1931#issuecomment-1724631857
@gerlowskija Any thoughts here? I'm on the fence. I don't really love the leniency with which we are reading boolean params here, it seems more useful for configuration files than it is for request parameters, but that's what other parts of the code are using, so I also want to consider consistency with other APIs. As far as I can tell, pre-Solr9 most Collections API parameters `ZkNodeProps`, which uses `Boolean.getBoolean` (case insensitive), so that's why they worked before and not now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
