epugh commented on PR #1957: URL: https://github.com/apache/solr/pull/1957#issuecomment-1733998142
Awesome work @stillalex .... Have you looked at https://github.com/apache/solr/pull/1954 (SOLR-14496) where I took a stab at adding credentials to the SolrCLI? It would be great if we used the same patterns in both there AND here... For example, I went with `-u eric:password` instead of seperate username and password params, mostly because curl does it that way! Sigh, in looking, looks like we use net.sourceforge.argparse4j instead of commons-cli... Wish we picked one CLI arg parser for them all! Lastly, are there any improvements here that could be reused in better handling of the CLI stuff? Would that change any of this code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
