janhoy commented on code in PR #1959:
URL: https://github.com/apache/solr/pull/1959#discussion_r1337160003
##########
solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java:
##########
@@ -65,7 +65,9 @@ void prepareConfiguration(NamedList<?> args) {
setDefaultIfNotConfigured("OTEL_EXPORTER_OTLP_PROTOCOL", "grpc");
setDefaultIfNotConfigured("OTEL_TRACES_SAMPLER", "parentbased_always_on");
setDefaultIfNotConfigured("OTEL_PROPAGATORS", "tracecontext,baggage");
- addOtelResourceAttributes(Map.of("host.name", System.getProperty("host")));
+ if (System.getProperty("host") != null) {
Review Comment:
I was surprised too to learn that SOLR_HOST is not always set in our start
script. And also learnt that `Map.of(k,v)` does null-check both for key and
value. Those two facts together caused this. Although only likely a problem in
dev environments, it's nice to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
