gerlowskija commented on PR #636:
URL: https://github.com/apache/solr-operator/pull/636#issuecomment-1744089624
> might as well include the solr.port.advertise here as well
I've added the necessary changes to work `solr.port.advertise` into
generated solr.xml files, though I think it'll need tweaked a bit.
The generated solr.xml was already set up to reference a different system
property called `hostPort`. It looks like we made pretty regular use of that
sysprop by default: even going so far as to error out of reconciliation
whenever a custom solr.xml didn't include `<int
name="hostPort">${hostPort:80}</int>`. This PR (right now) updates this all to
use `solr.port.advertise` instead.
Still doing a bit of testing on this and thinking through the upgrade
ramifications (little worried about what this change means for administrators
with custom solr.xml files that want to upgrade their operator), but this
should all be ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
