markrmiller commented on code in PR #75:
URL: https://github.com/apache/solr-sandbox/pull/75#discussion_r1344802109
##########
crossdc-consumer/src/main/java/org/apache/solr/crossdc/consumer/KafkaCrossDcConsumer.java:
##########
@@ -329,7 +329,7 @@ void
processResult(ConsumerRecord<String,MirroredSolrRequest> record, IQueueHand
log.trace("result=failed-resubmit");
}
metrics.counter("failed-resubmit").inc();
- kafkaMirroringSink.submit(record.value());
+ kafkaMirroringSink.submit(result.newItem());
Review Comment:
I honestly have no clue. I started on this from Anshum's original dump that
he extracted from some older code that did other things and integrated with
other components. I don't understand much about the naming in that class, and
since I haven't really had to touch before, it's just kind of survived. I'll
make sure to refactor it in a cleanup issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
