epugh commented on code in PR #1977:
URL: https://github.com/apache/solr/pull/1977#discussion_r1346062408


##########
solr/core/src/test/org/apache/solr/response/JSONWriterTest.java:
##########
@@ -314,4 +315,35 @@ public void testConstantsUnchanged() {
     assertEquals("arrntv", JSONWriter.JSON_NL_ARROFNTV);
     assertEquals("json.wrf", JSONWriter.JSON_WRAPPER_FUNCTION);
   }
+
+  @Test
+  public void testWfrJacksonJsonWriter() throws IOException {

Review Comment:
   I love the test...  Would it make sense to break out these tests?   Move to 
the JacksonJsonResponseWriterTest.java and JsonResponseWriterTest.java?  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to