clayburn commented on PR #2042: URL: https://github.com/apache/solr/pull/2042#issuecomment-1789740972
> I see this enables [the build cache](https://docs.gradle.org/current/userguide/build_cache.html) by default, which hopefully is a big positive benefit, at the expense of some local disk and risks of a misconfigured build leading to accidental caching. Note that this topic has been raised before: [issues.apache.org/jira/browse/SOLR-15603](https://issues.apache.org/jira/browse/SOLR-15603) which defaults to false via commented out part of gradle.properties. Solr's build (and Lucene) generates on first build from a [template](https://github.com/apache/solr/blob/main/gradle/template.gradle.properties?rgh-link-date=2023-11-01T21%3A46%3A36Z) which mentions org.gradle.caching. That should probably be removed entirely if we're going to enable build caching in this new ge.gradle file. This change actually will not. You still need the `org.gradle.caching=true` property for the configuration here to take effect. When that is true, then the configuration in this PR will be applied. > Even if the Crave integration is lacking; I don't think that should hold this up. I've done a little investigation on this so far, but without success. It would involve pulling files out of Gradle User Home back to the GitHub Actions runner. The `crave pull` command doesn't seem to let me access $HOME, which makes sense. I still have some avenues to explore, but I would not let that hold up this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
