janhoy commented on code in PR #1920:
URL: https://github.com/apache/solr/pull/1920#discussion_r1385198853
##########
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##########
@@ -218,44 +211,36 @@ private NodeConfig(
}
/**
- * Get the NodeConfig whether stored on disk, in ZooKeeper, etc. This may
also be used by custom
- * filters to load relevant configuration.
+ * Get the NodeConfig. This may also be used by custom filters to load
relevant configuration.
*
* @return the NodeConfig
*/
public static NodeConfig loadNodeConfig(Path solrHome, Properties
nodeProperties) {
- if
(StrUtils.isNotNullOrEmpty(System.getProperty("solr.solrxml.location"))) {
- log.warn(
- "Solr property solr.solrxml.location is no longer supported. Will
automatically load solr.xml from ZooKeeper if it exists");
- }
final SolrResourceLoader loader = new SolrResourceLoader(solrHome);
initModules(loader, null);
nodeProperties =
SolrXmlConfig.wrapAndSetZkHostFromSysPropIfNeeded(nodeProperties);
+
+ // TODO: Only job of this block is to
+ // delay starting a solr core to satisfy
+ // ZkFailoverTest test case...
Review Comment:
Rewrite ZkFailoverTest to enforce a failed restart of cluster in a different
way than relying on this sysprop hack...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
