iamsanjay commented on code in PR #2072:
URL: https://github.com/apache/solr/pull/2072#discussion_r1388302148
##########
solr/core/src/test/org/apache/solr/handler/admin/CoreAdminOperationTest.java:
##########
@@ -167,23 +167,29 @@ public void
testRenameUnexpectedFailuresResultIn500SolrException() {
@Test
public void testRenameMissingCoreParamResultsIn400SolrException() {
+ final var coreAdminHandler = mock(CoreAdminHandler.class);
+ final var callInfo1 = new CoreAdminHandler.CallInfo(coreAdminHandler,
mockRequest, null, null);
+
Review Comment:
Earlier the code exists at the start If all the required parameters are not
passed.
Now that validation is removed from here and CoreAdminOperation relies on
RenameCore class for it, test started failing as passed mock does not contain
the Handler object. That's why I created new mock and passed it. Also Let me
know If you want to change the variable name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
