gerlowskija commented on PR #2050: URL: https://github.com/apache/solr/pull/2050#issuecomment-1808761567
Alright, great news: with a good deal of help from @HoustonPutman I've been able to resolve the packaging/import issues mentioned in my last comment. Despite its name, it looks like the 'javascript' generator produces JS code that relies on a few server-side-NodeJS features (e.g. using `require` for module resolution/importing). It should really be named 'nodejs'. That said, we still managed to incorporate the library into the Admin UI by creating a [browserify](https://browserify.org/) bundle and copying that into `$webapp/libs/solr/index.js`. So this PR now adds code to our gradle build for this purpose. If we eventually publish this JS client we'll need to decide whether to publish in NodeJS/npm-ready or the browserify-bundled form. That'd be another great question for @MarcusSorealheis or anyone else more familiar with the JS ecosystem. ---- With these problems solved, the PR is ready to be merged! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
