epugh commented on PR #2074: URL: https://github.com/apache/solr/pull/2074#issuecomment-1817918099
I love that you added a test. Is the test as simple as it can be? I think you are testing (in this test) the parsing of json paths, however I see some references to the V2 api and maybe some commented out code? Is this test actually testing a packaget hat levers teh v2 api? Also, I wonder if the setup/tearDown can be similified? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
