epugh commented on code in PR #2044:
URL: https://github.com/apache/solr/pull/2044#discussion_r1402161824
##########
solr/core/src/java/org/apache/solr/cloud/OverseerConfigSetMessageHandler.java:
##########
@@ -98,6 +99,8 @@ public OverseerSolrResponse processMessage(ZkNodeProps
message, String operation
log.error("ConfigSet: {} operation: {} failed", configSetName,
operation, e);
}
+ addExceptionToNamedList(operation, e, results);
+
results.add("Operation " + operation + " caused exception:", e);
Review Comment:
Do we still need this after adding the `addExceptionToNamedList` call?
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java:
##########
@@ -450,6 +450,26 @@ static void processResponse(
}
}
+ static void logFailedOperation(final Object operation, final Exception e,
final String collName) {
+ if (collName == null) {
+ log.error("Operation {} failed", operation, e);
+ } else {
+ log.error("Collection {}}, operation {} failed", collName, operation, e);
Review Comment:
should `}}` be just `}`???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
