markrmiller commented on PR #91: URL: https://github.com/apache/solr-sandbox/pull/91#issuecomment-1828655126
Looks fine to me. We may want to make it an enum or something instead of a boolean though, so we are free to easily add further options. I haven't brought it over yet, but you can actually choose 3 or 4 delete by query options on the wip branch. Don't expand, expand and use deep paging, and expand without deep paging. I can't remember if there was a fourth. We may just end up with the two, but if we do add another, it would be nice not to have to break or transition the API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
