tflobbe commented on code in PR #2100:
URL: https://github.com/apache/solr/pull/2100#discussion_r1408524274
##########
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java:
##########
@@ -279,12 +282,20 @@ public void init(PluginInfo info) {
int soTimeout =
getParameter(args, HttpClientUtil.PROP_SO_TIMEOUT,
HttpClientUtil.DEFAULT_SO_TIMEOUT, sb);
+ int keystoreReloadIntervalSecs =
Review Comment:
I'm fine either way. I didn't like much to "leak" the server-side system
properties into the client, but it's true that it's what we doing with other
settings, so maybe better to favor consistency.
I did explicitly disabled this for some of those short-lived clients to
prevent them from starting and stopping the scanner.
Also, I was missing the setting for the update client, this new code you
suggested is handling that. Added a test for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
